[U-Boot] [PATCH v3 03/18] x86: sysreset: Separate out the EFI code

Bin Meng bmeng.cn at gmail.com
Tue May 7 09:21:16 UTC 2019


On Fri, May 3, 2019 at 12:52 AM Simon Glass <sjg at chromium.org> wrote:
>
> The EFI implementation of reset sits inside the driver and is called
> directly from outside the driver, breaking the normal driver-model
> conventions. Worse, it passed NULL as the device pointer, hoping that
> the called function won't use it, which breaks as soon as code is added
> to use it.
>
> Separate out the implementation to improve the situation enough to allow
> a future patch to add new sysreset features.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> ---
>
> Changes in v3: None
> Changes in v2:
> - Add new patch to separate out the EFI code in sysreset
>
>  drivers/sysreset/sysreset_x86.c | 16 +++++++++++-----
>  1 file changed, 11 insertions(+), 5 deletions(-)
>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list