[U-Boot] [PATCH v6 09/13] rockchip: rk3399: Add Nanopc T4 board support

[Jagan Teki]

On Tue, May 7, 2019 at 2:42 PM Paul Kocialkowski
<paul.kocialkowski at bootlin.com> wrote:
>
> Hi,
>
> On Sat, 2019-04-27 at 17:18 +0530, Jagan Teki wrote:
> > diff --git a/board/rockchip/evb_rk3399/MAINTAINERS b/board/rockchip/evb_rk3399/MAINTAINERS
> > index ae43805a6a..5917abb9c1 100644
> > --- a/board/rockchip/evb_rk3399/MAINTAINERS
> > +++ b/board/rockchip/evb_rk3399/MAINTAINERS
> > @@ -6,6 +6,12 @@ F:      include/configs/evb_rk3399.h
> >  F:      configs/evb-rk3399_defconfig
> >  F:      configs/firefly-rk3399_defconfig
> >
> > +NANOPC-T4
> > +M:   Jagan Teki <jagan at amarulasolutions.com>
> > +S:   Maintained
> > +F:   configs/nanopic-t4-rk3399_defconfig
> > +F:   arch/arm/dts/rk3399-nanopic-t4-u-boot.dtsi
> > +
>
> Mhh, I feel like each new board that you are introducing should have
> its own board directory -- this board is definitely not a rk3399 evb
> made by rockchip, but another board.

The behavior of all these added boards remains similar like evb, so
instead of adding separate board directory with redundant code this
patch uses existing stuff. Idea is to make common board directory as
rk3399, that have separate rework planed.

>
> I have already patches to split that for the firefly-rk3399, but I
> cannot really test them outside of building.

Do you have any specific board code for this firefly, I would suggest
to keep use evb since most of the peripheral handling in rockchip done
via dt so we can go-ahead w/o separating the board code atleast for
these boards.

>
> >  NANOPI-M4
> >  M:   Jagan Teki <jagan at amarulasolutions.com>
> >  S:   Maintained
> > diff --git a/configs/nanopc-t4-rk3399_defconfig b/configs/nanopc-t4-rk3399_defconfig
> > new file mode 100644
> > index 0000000000..7ba4f85485
> > --- /dev/null
> > +++ b/configs/nanopc-t4-rk3399_defconfig
> > @@ -0,0 +1,58 @@
>
> Also I don't see which TARGET is selected here, is there a fallback on
> the RK3399 EVB for the rk3399 platform?

It will select the EVB from mach-rockchip by default, ie reason I
didn't mentioned explicitly.