[U-Boot] [PATCH] arm: socfpga: Re-add support for Aries MCV SoM and MCVEVK board

[Wolfgang Grandegger]

Am 06.05.19 um 19:55 schrieb Marek Vasut:
> On 5/6/19 5:45 PM, Wolfgang Grandegger wrote:
>> Re-add support for Aries Embedded MCV SoM, which is CycloneV based
>> and the associated MCVEVK baseboard. The board can boot from eMMC.
>> Ethernet and USB is supported.
> 
> I thought the board is now called MCVEVP , not MCVEVK ?

Yes, the new base board is called MCVEVP and the old MCVEVK. The patch
supports both. Linux still uses the name of the old board. Not sure if
it's worth changing the name.

> 
>> The Aries Embedded boards have been removed with commit 03b54997d568
>> ("board/aries: Remove"). I will now take care of them.
> 
> If the DTs come from Linux, the exact commit should be stated here.

Yes, it's from the most recent version 5.1 of Linux.

> [...]
> 
>> diff --git a/.travis.yml b/.travis.yml
>> index 8bd49ef..714b92e 100644
>> --- a/.travis.yml
>> +++ b/.travis.yml
>> @@ -230,7 +230,7 @@ matrix:
>>          - BUILDMAN="sun50i"
>>      - name: "buildman catch-all ARM"
>>        env:
>> -        - BUILDMAN="arm -x arm11,arm7,arm9,aarch64,at91,freescale,kirkwood,mvebu,siemens,tegra,uniphier,mx,samsung,sunxi,am33xx,omap,pxa,rockchip,toradex,socfpga,k2,xilinx"
>> +        - BUILDMAN="arm -x arm11,arm7,arm9,aarch64,aries,at91,freescale,kirkwood,mvebu,siemens,tegra,uniphier,mx,samsung,sunxi,am33xx,omap,pxa,rockchip,toradex,socfpga,k2,xilinx"
> 
> What's this about ?

I don't know ;). That's from the original U-Boot support.

> 
>>      - name: "buildman sandbox x86"
>>        env:
>>          - BUILDMAN="sandbox x86"
> 
> [...]
> 
>> diff --git a/arch/arm/dts/socfpga_cyclone5_mcvevk-u-boot.dtsi b/arch/arm/dts/socfpga_cyclone5_mcvevk-u-boot.dtsi
>> new file mode 100644
>> index 0000000..1afaa86
>> --- /dev/null
>> +++ b/arch/arm/dts/socfpga_cyclone5_mcvevk-u-boot.dtsi
>> @@ -0,0 +1,38 @@
>> +// SPDX-License-Identifier: GPL-2.0+
>> +/*
>> + * U-Boot additions
>> + *
>> + * Copyright (C) 2015 Marek Vasut <marex at denx.de>
>> + * Copyright (C) 2018 Wolfgang Grandegger <wg at aries-embedded.de>
> 
> It's 2019 now .
> [...]
> 
>> diff --git a/board/aries/mcvevk/MAINTAINERS b/board/aries/mcvevk/MAINTAINERS
>> new file mode 100644
>> index 0000000..0e97941
>> --- /dev/null
>> +++ b/board/aries/mcvevk/MAINTAINERS
>> @@ -0,0 +1,6 @@
>> +Aries MCVEVK BOARD
>> +M:	Wolfgang Grandegger <wg at aries-embedded.de>
>> +S:	Maintained
>> +F:	board/aries/mcvevk/
>> +F:	include/configs/socfpga_mcvevk.h
>> +F:	configs/socfpga_mcvevk_defconfig
> 
> DTs are missing in the list
> 
> [...]
> 
>> +/* Extra Environment */
>> +#define CONFIG_EXTRA_ENV_SETTINGS					\
>> +	"consdev=ttyS0\0"						\
>> +	"baudrate=115200\0"						\
>> +	"bootscript=boot.scr\0"						\
>> +	"bootdev=/dev/mmcblk0p2\0"					\
>> +	"rootdev=/dev/mmcblk0p3\0"					\
> 
> Can you switch this to UUID/PARTUUID instead of ad-hoc hard-coded eMMC
> partitions ?
> 
> [...]

This will only work with GPT partition tables, right? Buildroot still
uses MBR.

Will have a look and fix the issues.

Thanks,

Wolfgang.