[U-Boot] [PATCH] arm: socfpga: Re-add support for Aries MCV SoM and MCVEVK board

[Wolfgang Grandegger]

Am 08.05.19 um 16:14 schrieb Marek Vasut:
> On 5/8/19 4:10 PM, Wolfgang Grandegger wrote:
>>
>> Am 07.05.19 um 19:02 schrieb Marek Vasut:
>>> On 5/7/19 6:25 PM, Wolfgang Grandegger wrote:
>>>> Am 06.05.19 um 19:55 schrieb Marek Vasut:
>>>>> On 5/6/19 5:45 PM, Wolfgang Grandegger wrote:
>>>>>> Re-add support for Aries Embedded MCV SoM, which is CycloneV based
>>>>>> and the associated MCVEVK baseboard. The board can boot from eMMC.
>>>>>> Ethernet and USB is supported.
>>>>>
>>>>> I thought the board is now called MCVEVP , not MCVEVK ?
>>>>
>>>> Yes, the new base board is called MCVEVP and the old MCVEVK. The patch
>>>> supports both. Linux still uses the name of the old board. Not sure if
>>>> it's worth changing the name.
>>>>
>>>>>
>>>>>> The Aries Embedded boards have been removed with commit 03b54997d568
>>>>>> ("board/aries: Remove"). I will now take care of them.
>>>>>
>>>>> If the DTs come from Linux, the exact commit should be stated here.
>>>>
>>>> Yes, it's from the most recent version 5.1 of Linux.
>>>
>>> Do the 12-byte hash should be in the commit message.
>>>
>>>>> [...]
>>>>>
>>>>>> diff --git a/.travis.yml b/.travis.yml
>>>>>> index 8bd49ef..714b92e 100644
>>>>>> --- a/.travis.yml
>>>>>> +++ b/.travis.yml
>>>>>> @@ -230,7 +230,7 @@ matrix:
>>>>>>          - BUILDMAN="sun50i"
>>>>>>      - name: "buildman catch-all ARM"
>>>>>>        env:
>>>>>> -        - BUILDMAN="arm -x arm11,arm7,arm9,aarch64,at91,freescale,kirkwood,mvebu,siemens,tegra,uniphier,mx,samsung,sunxi,am33xx,omap,pxa,rockchip,toradex,socfpga,k2,xilinx"
>>>>>> +        - BUILDMAN="arm -x arm11,arm7,arm9,aarch64,aries,at91,freescale,kirkwood,mvebu,siemens,tegra,uniphier,mx,samsung,sunxi,am33xx,omap,pxa,rockchip,toradex,socfpga,k2,xilinx"
>>>>>
>>>>> What's this about ?
>>>>
>>>> I don't know ;). That's from the original U-Boot support.
>>>>
>>>
>>> Is it needed ?
>>
>> I can't tell what it's good for! The header states: "build U-Boot on
>> Travis CI". I will remove it!
>>
>>>
>>> [...]
>>>
>>>>> [...]
>>>>>
>>>>>> +/* Extra Environment */
>>>>>> +#define CONFIG_EXTRA_ENV_SETTINGS					\
>>>>>> +	"consdev=ttyS0\0"						\
>>>>>> +	"baudrate=115200\0"						\
>>>>>> +	"bootscript=boot.scr\0"						\
>>>>>> +	"bootdev=/dev/mmcblk0p2\0"					\
>>>>>> +	"rootdev=/dev/mmcblk0p3\0"					\
>>>>>
>>>>> Can you switch this to UUID/PARTUUID instead of ad-hoc hard-coded eMMC
>>>>> partitions ?
>>>>>
>>>>> [...]
>>>>
>>>> This will only work with GPT partition tables, right? Buildroot still
>>>> uses MBR.
>>>>
>>>> Will have a look and fix the issues.
>>>
>>> Nope, it works with both GPT and MBR, look at partuuid command .
>>
>> Unfortunately, Buildroot does not set useful UUIDs:
>>
>>   => part list mmc 0
>>   Partition Map for MMC device 0  --   Partition Type: DOS
>>
>>   Part	Start Sector	Num Sectors	UUID		Type
>>     1	2048      	2048      	00000000-01	a2
>>     2	4096      	65536     	00000000-02	0c Boot
>>     3	69632     	1024000   	00000000-03	83
>>
>> Therefore I will stick with the device name.
> 
> Hum, too bad. Once someone attaches another SD card to your board, it
> might scramble the enumeration in Linux. Maybe it's something to fix in
> the longer run ?

There is no SD-Card connected to the HPS, just the eMMC. Anyway, I will
use PARTUUID. Our Buildroot port provides it's own env setting and
therefore there should be no conflict (there are more differences, e.g.
zImage instead of ftImage).

Wolfgang