[U-Boot] [PATCH v2 1/1] imx8: cpu: fix warning for cpu_imx_get_temp

[Igor Opaniuk]

On Mon, May 13, 2019 at 5:56 PM Igor Opaniuk <igor.opaniuk at toradex.com> wrote:
>
> cpu_imx_get_temp() definition is wrapped with a ifdef macro, which leads
> to warnings if CONFIG_IMX_SCU_THERMAL isn't defined and there are still
> references to this function, as, for example, in cpu_imx_get_desc().
> Drop ifdef as linker will automatically remove the function
> in case CONFIG_IMX_SCU_THERMAL is not enabled.
>
> Fix warning:
> arch/arm/mach-imx/imx8/cpu.c: In function ‘cpu_imx_get_desc’:
> arch/arm/mach-imx/imx8/cpu.c:612:40: warning: implicit declaration of
> function ‘cpu_imx_get_temp’; did you mean ‘cpu_imx_get_desc’?
> [-Wimplicit-function-declaration]
>     ret = snprintf(buf, size, " at %dC", cpu_imx_get_temp());
>                                          ^~~~~~~~~~~~~~~~
>                                          cpu_imx_get_desc
>                                          cpu_imx_get_desc
>
> Fixes: 82467cb217 ("imx8: cpu: get temperature when print cpu desc")
> Signed-off-by: Igor Opaniuk <igor.opaniuk at toradex.com>
> ---
>
> v2:
> - address Stefan's comments and drop the ifdef instead
>
>  arch/arm/mach-imx/imx8/cpu.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/mach-imx/imx8/cpu.c b/arch/arm/mach-imx/imx8/cpu.c
> index 12596c6387..1be63af7f3 100644
> --- a/arch/arm/mach-imx/imx8/cpu.c
> +++ b/arch/arm/mach-imx/imx8/cpu.c
> @@ -574,7 +574,6 @@ const char *get_core_name(void)
>                 return "?";
>  }
>
> -#if defined(CONFIG_IMX_SCU_THERMAL)
>  static int cpu_imx_get_temp(void)
>  {
>         struct udevice *thermal_dev;
> @@ -593,7 +592,6 @@ static int cpu_imx_get_temp(void)
>
>         return cpu_tmp;
>  }
> -#endif
>
>  int cpu_imx_get_desc(struct udevice *dev, char *buf, int size)
>  {
> --
> 2.17.1
>

Please ignore this patch

-- 
Best regards - Freundliche Grüsse - Meilleures salutations

Senior Development Engineer,
Igor Opaniuk

Toradex AG
Altsagenstrasse 5 | 6048 Horw/Luzern | Switzerland | T: +41 41 500 48
00 (main line)