[U-Boot] [PATCH 05/14] arm: socfpga: Move Stratix10 and Agilex system manager common code

[Marek Vasut]

On 5/14/19 7:47 AM, Ley Foon Tan wrote:
> On Fri, May 10, 2019 at 8:17 PM Marek Vasut <marex at denx.de> wrote:
>>
>> On 5/10/19 7:54 AM, Ley Foon Tan wrote:
>>> Move Stratix10 and Agilex system manager common code to system_manager.h.
>>>
>>> Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
>>
>> This becomes quite a bit of ifdeffery . Why don't you have the
>> system_manager.h include system_manager_$soc.h like e.g. here?
>>
>> http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/mach-rmobile/include/mach/rmobile.h
>>
>> --
>> Best regards,
>> Marek Vasut
> We already have similar thing for Gen5. A10 and S10 includes. But, S10
> and Agilex share some common defines/functions.
> I can move S10 and Agilex common code to a separate file and include
> in their header file.

I think that'd improve the code .

-- 
Best regards,
Marek Vasut