[U-Boot] [PATCH v2 1/3] arm: exynos: arndale: Remove unused CONFIG_POWER and CONFIG_POWER_I2C

Minkyu Kang mk7.kang at samsung.com
Thu May 16 07:33:26 UTC 2019


Hi,

On 11/05/2019 20:24, Krzysztof Kozlowski wrote:
> The CONFIG_POWER and CONFIG_POWER_I2C were introduced in
> include/configs/exynos5-common.h in commit 19bd3aaa5991 ("exynos5: fix
> build break by adding CONFIG_POWER") and then it propagated up to
> include/configs/arndale.h.  However before that commit, there was no
> build break at all on Arndale and SMDK5250 boards.  It seems the commit
> fixed nothing and just added unused defines.
> 
> In fact, the Arndale board is not configuring its PMIC (S5M8767) which
> uses I2C bus.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk at kernel.org>
> Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> ---
> 
> Not tested on Arndale board. Testing is welcomed.
> 
> Changes since v1:
> 1. Add Simon's tag.
> 2. Reorder patches - first remove CONFIG_POWER_I2C, then
>    CONFIG_DM_I2C_COMPAT.
> ---
>  include/configs/arndale.h | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/include/configs/arndale.h b/include/configs/arndale.h
> index dd321c4748d0..841f3616482b 100644
> --- a/include/configs/arndale.h
> +++ b/include/configs/arndale.h
> @@ -29,10 +29,6 @@
>  
>  #define CONFIG_SYS_INIT_SP_ADDR	CONFIG_IRAM_STACK
>  
> -/* PMIC */
> -#define CONFIG_POWER
> -#define CONFIG_POWER_I2C
> -
>  #define CONFIG_PREBOOT
>  
>  #define CONFIG_S5P_PA_SYSRAM	0x02020000
> @@ -41,8 +37,4 @@
>  /* The PERIPHBASE in the CBAR register is wrong on the Arndale, so override it */
>  #define CONFIG_ARM_GIC_BASE_ADDRESS	0x10480000
>  
> -/* Power */
> -#define CONFIG_POWER
> -#define CONFIG_POWER_I2C
> -
>  #endif	/* __CONFIG_H */
> 

applied to u-boot-samsung.

Thanks,
Minkyu Kang.


More information about the U-Boot mailing list