[U-Boot] [PATCH 2/3] sysreset: move stm32mp sysreset poweroff implementation to sysreset uclass

Urja Rannikko urjaman at gmail.com
Thu May 16 11:41:03 UTC 2019


Hi,

On Tue, May 14, 2019 at 4:07 PM Patrice CHOTARD <patrice.chotard at st.com> wrote:
>
> Hi Urja
>
> This patch doesn't compile using the stm32mp15_trusted_defconfig
> configuration:
>
> ...
>   LD      drivers/pinctrl/built-in.o
>   LD      drivers/core/built-in.o
>   LD      drivers/mmc/built-in.o
>   LD      drivers/built-in.o
> drivers/sysreset/built-in.o: In function `do_poweroff':
> /local/home/nxp11987/projects/community/u-boot.denx/drivers/sysreset/sysreset-uclass.c:123:
> multiple definition of `do_poweroff'
> drivers/firmware/built-in.o:/local/home/nxp11987/projects/community/u-boot.denx/drivers/firmware/psci.c:134:
> first defined here
> make[1]: *** [drivers/built-in.o] Error 1
> make: *** [drivers] Error 2
> build error !!
>
>
> I suggest you to update your patch with :
>
> config PMIC_STPMIC1
>         bool "Enable support for STMicroelectronics STPMIC1 PMIC"
>         depends on DM_PMIC && DM_I2C
> -       select SYSRESET_CMD_POWEROFF if CMD_POWEROFF
> +       select SYSRESET_CMD_POWEROFF if CMD_POWEROFF && !ARM_PSCI_FW
>         ---help---
>         The STPMIC1 PMIC provides 4 BUCKs, 6 LDOs, 1 VREF and 2 power switches.
>         It is accessed via an I2C interface. The device is used with STM32MP1
>         SoCs. This driver implements register read/write operations.

I'll do that in v2, thanks for the test.

-- 
Urja Rannikko


More information about the U-Boot mailing list