[U-Boot] [PATCH] Makefile: Prioritize external dtb if defined

Michal Simek michal.simek at xilinx.com
Sun May 19 18:07:03 UTC 2019


On 19. 05. 19 15:15, Marek Vasut wrote:
> On 5/20/19 12:08 AM, Tom Rini wrote:
>> On Mon, May 20, 2019 at 12:03:45AM +0200, Marek Vasut wrote:
>>> On 5/19/19 10:44 PM, Tom Rini wrote:
>>>> On Mon, Mar 25, 2019 at 03:55:16PM +0100, Michal Simek wrote:
>>>>
>>>>> Prioritize external dtb if its passed via EXT_DTB
>>>>> than the dtb that was built in the tree. With this
>>>>> patch it appends the specified external dtb to
>>>>> the u-boot image.
>>>>>
>>>>> Signed-off-by: Michal Simek <michal.simek at xilinx.com>
>>>>> Signed-off-by: Siva Durga Prasad Paladugu <siva.durga.paladugu at xilinx.com>
>>>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>>>
>>>> Applied to u-boot/master, thanks!
>>>
>>> The R-Car Gen3 boards (r8a779{5,6}*_salvator-x_defconfig) u-boot.bin
>>> size grew from 986 kiB to 1240 kiB with this patch, rendering the boards
>>> unbootable. I expect there to be more such cases, so please revert until
>>> there's new version which has this fixed.
>>
>> I must have messed something up when re-adjusting this to apply to top
>> of tree.  I'll revert this, thanks for reporting.  Michal, please rebase
>> the original patch and resend, thanks!
> 
> My guess is that it has to do with the LZO compression of the DTBs on
> Gen3 , that fit-blob.itb is probably appended uncompressed or something.
> 

This patch is already applied to the tree (commit below). It means you
please revert what was added by: 3eaf6dcd9362b56e3217559401287dd8fa35b5b2

Thanks,
Michal

commit c8c5e2b84d5d928472b68a51854b727ee90295b2
Author:     Michal Simek <michal.simek at xilinx.com>
AuthorDate: Sat Mar 23 11:13:00 2019 +0530
Commit:     Michal Simek <michal.simek at xilinx.com>
CommitDate: Tue Apr 16 11:52:02 2019 +0200

    Makefile: Prioritize external dtb if defined

    Prioritize external dtb if its passed via EXT_DTB
    than the dtb that was built in the tree. With this
    patch it appends the specified external dtb to
    the u-boot image.

    Signed-off-by: Michal Simek <michal.simek at xilinx.com>
    Signed-off-by: Siva Durga Prasad Paladugu
<siva.durga.paladugu at xilinx.com>
    Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list