[U-Boot] [PATCH] drivers: core: use strcmp when find device by name

Simon Glass sjg at chromium.org
Mon May 20 12:16:52 UTC 2019


Hi Peng,

On Wed, 15 May 2019 at 05:57, Peng Fan <peng.fan at nxp.com> wrote:
>
> Hi Simon,
>
> > Subject: Re: [PATCH] drivers: core: use strcmp when find device by name
> >
> > On Sun, 28 Apr 2019 at 03:43, Peng Fan <peng.fan at nxp.com> wrote:
> > >
> > > `if (!strncmp(dev->name, name, strlen(name)))` might find out the
> > > wrong device, it might find out `dram_pll_ref_sel`, when name is
> > > `dram_pll`. So use strcmp to avoid such issue.
> > >
> > > Signed-off-by: Peng Fan <peng.fan at nxp.com>
> > > ---
> > >  drivers/core/uclass.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> >
> > This seems to match the function description in the header file, too.
>
> Will you pick up this patch? Not see this patch in your tree.

I found that this causes a test failure - can you try 'make qcheck'
and see if you can figure out what is going on?

Regards,
Simon


More information about the U-Boot mailing list