[U-Boot] [PATCH] gpio: dwapb_gpio: fix broken dev->node
Simon Goldschmidt
simon.k.r.goldschmidt at gmail.com
Tue May 21 20:03:12 UTC 2019
commit 1b898ffc040b ("gpio: dwapb_gpio: convert to livetree") introduced
a bug in that dev->node of the gpio chip was accidentally set to the
of_node of its bank subnode.
What it meant to do was assign subdev->node, not dev->node.
While this doesn't affect too many use cases, iterating over the gpio
chip's properties doesn't work any more after that, so fix this.
Fixes: commit 1b898ffc040b ("gpio: dwapb_gpio: convert to livetree")
Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
---
This fixes a commit that is only 12 days old, so it's a fix for v2019.07
---
drivers/gpio/dwapb_gpio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/dwapb_gpio.c b/drivers/gpio/dwapb_gpio.c
index 04a2381acd..d6887a396a 100644
--- a/drivers/gpio/dwapb_gpio.c
+++ b/drivers/gpio/dwapb_gpio.c
@@ -190,7 +190,7 @@ static int gpio_dwapb_bind(struct udevice *dev)
if (ret)
return ret;
- dev->node = node;
+ subdev->node = node;
bank++;
}
--
2.20.1
More information about the U-Boot
mailing list