[U-Boot] [PATCH] core: ofnode: Have ofnode_read_u32_default return a u32

Simon Glass sjg at chromium.org
Wed May 22 13:21:32 UTC 2019


On Fri, 10 May 2019 at 11:48, Trent Piepho <tpiepho at impinj.com> wrote:
>
> It was returning an int, which doesn't work if the u32 it is reading,
> or the default value, will overflow a signed int.
>
> While it could be made to work, when using a C standard/compiler where
> casting negative signed values to unsigned has a defined behavior,
> combined with careful casting, it seems obvious one is meant to use
> ofnode_read_s32_default() with signed values.
>
> Cc: Simon Glass <sjg at chromium.org>
> Signed-off-by: Trent Piepho <tpiepho at impinj.com>
> ---
>  drivers/core/ofnode.c | 2 +-
>  include/dm/ofnode.h   | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)

Applied to u-boot-dm, thanks!


More information about the U-Boot mailing list