[U-Boot] [RESEND][PATCH v2] armv8: Add workaround for USB erratum A-050106

Prabhakar Kushwaha prabhakar.kushwaha at nxp.com
Thu May 23 03:49:36 UTC 2019


Dear Ran,

> -----Original Message-----
> From: Ran Wang
> Sent: Thursday, May 23, 2019 9:16 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha at nxp.com>
> Cc: York Sun <york.sun at nxp.com>; u-boot at lists.denx.de; Albert Aribaud
> <albert.u.boot at aribaud.net>
> Subject: RE: [RESEND][PATCH v2] armv8: Add workaround for USB erratum A-
> 050106
> 
> Hi Prabhakar,
> 
> On Tuesday, May 21, 2019 22:48, Prabhakar Kushwaha wrote:
> >
> > Dear Ran
> >
> <snip>
> > >
> > > USB3.0 Receiver needs to enable fixed equalization for each of PHY
> > > instances in an SOC. This is similar to erratum A-009007, but this
> > > one is for LX2160A, and the register value is different.
> > >
> > > Signed-off-by: Ran Wang <ran.wang_1 at nxp.com>
> > > ---
> >
> > This patch is for adding workaround for errata A-050106.
> > But you are modifying erratum_a008997().
> >
> > Please avid hidden changes in a patch.
> > I will suggest to generate 2 patches one for A-050106 and other for
> > a008997
> 
> Actually the information ' @@ -139,7 +139,8 @@  static void
> erratum_a008997(void) '
> automatically generated by git is not quite right, the change I made is within
> macro PROGRAM_USB_PHY_RX_OVRD_IN_HI rather than function
> erratum_a008997(void) .
> You can look into the src file arch/arm/cpu/armv8/fsl-layerscape/soc.c for
> details :)
> 


@@ -139,7 +139,8 @@ static void erratum_a008997(void)
 	out_be16((phy) + SCFG_USB_PHY_RX_OVRD_IN_HI, USB_PHY_RX_EQ_VAL_3);	\
 	out_be16((phy) + SCFG_USB_PHY_RX_OVRD_IN_HI, USB_PHY_RX_EQ_VAL_4)
 
-#elif defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LS1088A)
+#elif defined(CONFIG_ARCH_LS2080A) || defined(CONFIG_ARCH_LS1088A) || \
+	defined(CONFIG_ARCH_LX2160A)

As per my understanding this change is being done in  erratum_a008997
Let me know, if am not seeing it correctly.

--pk
 


More information about the U-Boot mailing list