[U-Boot] [PATCH] mmc: Move tegra loopback disable option to be under tegra

Marcel Ziswiler marcel.ziswiler at toradex.com
Thu May 23 09:02:07 UTC 2019


On Mon, 2019-04-01 at 23:05 +0000, Trent Piepho wrote:
> This is a configuration option specific to the tegra controller.
> 
> Doing it this way makes it show up directly under the tegra
> controller
> option, indented one level, as "Disable external clock loopback".
> 
> The way it is now, it shows up at the end of the controller list, not
> indented, as if it's some kind of generic MMC configuration option.
> 
> Cc: Marcel Ziswiler <marcel.ziswiler at toradex.com>
> Cc: Simon Glass <sjg at chromium.org>
> Cc: Jaehoon Chung <jh80.chung at samsung.com>
> Cc: Tom Warren <twarren at nvidia.com>
> Signed-off-by: Trent Piepho <tpiepho at impinj.com>

Acked-by: Marcel Ziswiler <marcel.ziswiler at toradex.com>

> ---
>  drivers/mmc/Kconfig | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/mmc/Kconfig b/drivers/mmc/Kconfig
> index 08c2dd2541..759a1cceb4 100644
> --- a/drivers/mmc/Kconfig
> +++ b/drivers/mmc/Kconfig
> @@ -542,6 +542,17 @@ config MMC_SDHCI_TEGRA
>  
>  	  If unsure, say N.
>  
> +config TEGRA124_MMC_DISABLE_EXT_LOOPBACK
> +	bool "Disable external clock loopback"
> +	depends on MMC_SDHCI_TEGRA && TEGRA124
> +	help
> +	  Disable the external clock loopback and use the internal one
> on SDMMC3
> +	  as per the SDMMC_VENDOR_MISC_CNTRL_0 register's SDMMC_SPARE1
> bits
> +	  being set to 0xfffd according to the TRM.
> +
> +	  TODO(marcel.ziswiler at toradex.com): Move to device tree
> controlled
> +	  approach once proper kernel integration made it mainline.
> +
>  config MMC_SDHCI_ZYNQ
>  	bool "Arasan SDHCI controller support"
>  	depends on ARCH_ZYNQ || ARCH_ZYNQMP || ARCH_VERSAL
> @@ -627,17 +638,6 @@ config FSL_ESDHC
>  
>  endif
>  
> -config TEGRA124_MMC_DISABLE_EXT_LOOPBACK
> -	bool "Disable external clock loopback"
> -	depends on MMC_SDHCI_TEGRA && TEGRA124
> -	help
> -	  Disable the external clock loopback and use the internal one
> on SDMMC3
> -	  as per the SDMMC_VENDOR_MISC_CNTRL_0 register's SDMMC_SPARE1
> bits
> -	  being set to 0xfffd according to the TRM.
> -
> -	  TODO(marcel.ziswiler at toradex.com): Move to device tree
> controlled
> -	  approach once proper kernel integration made it mainline.
> -
>  endmenu
>  
>  config SYS_FSL_ERRATUM_ESDHC111


More information about the U-Boot mailing list