[U-Boot] [PATCH 0/2] efi_loader: implement deprecated Unicode collation protocol

[Heinrich Schuchardt]

On 5/24/19 3:02 AM, AKASHI Takahiro wrote:
> Heinrich,
>
> On Thu, May 16, 2019 at 07:34:54PM +0200, Heinrich Schuchardt wrote:
>> In EFI 1.10 a version of the Unicode collation protocol using ISO 639-2
>> language codes existed. This protocol is not part of the UEFI specification
>> any longer. Unfortunately it is required to run the UEFI Self Certification
>> Test (SCT) II, version 2.6, 2017. So we implement it here for the sole
>> purpose of running the SCT. It can be removed once a compliant SCT is
>> available.
>
> I remember that Alex always rejected this kind of patch, saying
> that an upstream (SCT in this case) should be fixed in the first place.
>
> Do you want to change this policy?
> (I'm just asking.)

I am using SCT a lot to test my patches. I want to be able to run the
tests on the final code.

I have raised a ticket for upstream SCT but did not see any reaction up
to now.

Making this deprecated protocol a config option deselected by default is
the most plausible solution to me. In the Kconfig comment I made it
clear that this protocol is going to be removed when the SCT has been
corrected.

Best regards

Heinrich

>
> -Takahiro Akashi
>
>> The configuration option defaults to no.
>>
>> Heinrich Schuchardt (2):
>>   efi_loader: rename Unicode collation protocol 2 variables
>>   efi_loader: implement deprecated Unicode collation protocol
>>
>>  include/efi_api.h                      |  5 ++++
>>  include/efi_loader.h                   |  9 +++++--
>>  lib/efi_loader/Kconfig                 | 15 ++++++++++--
>>  lib/efi_loader/Makefile                |  2 +-
>>  lib/efi_loader/efi_root_node.c         |  7 +++++-
>>  lib/efi_loader/efi_unicode_collation.c | 33 +++++++++++++++++++++++---
>>  lib/efi_selftest/Makefile              |  3 ++-
>>  7 files changed, 64 insertions(+), 10 deletions(-)
>>
>> --
>> 2.20.1
>>
>