[U-Boot] [PATCH 1/2 v2] mips: mt76xx: Remove cache workaround and select SYS_MALLOC_CLEAR_ON_INIT

Daniel Schwierzeck daniel.schwierzeck at gmail.com
Fri May 24 14:13:47 UTC 2019



Am 23.05.19 um 07:55 schrieb Stefan Roese:
> With commit 06985289d452 ("watchdog: Implement generic watchdog_reset()
> version") the init sequence has changed in arch_misc_init(), resulting
> in a re-appearance of the d-cache issue on MT7688 boards (e.g. gardena).
> When this happens, the first (or sometimes later ones as well) TFTP
> command hangs and does not complete correctly. This leads to the
> assumption that the d-cache is not in a clean state once the ethernet
> driver is called (d-cache is used here for the buffers). The old work-
> around with the cache flush somehow does not work any more now with
> the new code change.
> 
> To fix this issue, this patch now removes the old workaround and selects
> CONFIG_SYS_MALLOC_CLEAR_ON_INIT for ARCH_MTMIPS. With this option the
> complete malloc area is initialized with zeros (cache lines are touched).
> Testing has shown that this also fixes the issue on the MT7688 boards.
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Suggested-by: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> ---
> v2:
> - As suggested by Daniel, remove the workaround (hack) and select
>   CONFIG_SYS_MALLOC_CLEAR_ON_INIT instead
> 
>  arch/mips/Kconfig           |  2 +-
>  arch/mips/mach-mtmips/cpu.c | 15 ---------------
>  2 files changed, 1 insertion(+), 16 deletions(-)
> 

applied to u-boot-mips, thanks.

-- 
- Daniel


More information about the U-Boot mailing list