[U-Boot] [PATCH 2/2] ARM: davinci: SPL: fix BSS initialization

[Sekhar Nori]

On 24/05/19 6:51 PM, Adam Ford wrote:
>>>> diff --git a/arch/arm/mach-davinci/spl.c b/arch/arm/mach-davinci/spl.c
>>>> index 103639e34757..117b5ee836f8 100644
>>>> --- a/arch/arm/mach-davinci/spl.c
>>>> +++ b/arch/arm/mach-davinci/spl.c
>>>> @@ -33,10 +33,14 @@ void putc(char c)
>>>>
>>>>  void spl_board_init(void)
>>>>  {
>>>> -       arch_cpu_init();
>>>>         preloader_console_init();
>>>>  }
>>>>
>>>> +void board_init_f(ulong dummy)
>>>> +{
>>>> +       arch_cpu_init();

>>> What about a reference to board_early_init_f()?
>>> Looking at other boards, it appears that we should call that here.
>>> Both the LCDK and da850 evm have the function enabled to configure the
>>> DSP.

>> This is only needed at U-Boot stage, right? Looks like it will be called
>> because CONFIG_BOARD_EARLY_INIT_F is enabled.

> That is my understanding.

Alright, so I wont do anything about board_early_init_f() in this series.

> 
> Thanks for being flexible on this.  Sorry I broke the lcdk, but I'm
> willing to help modernize it as well (ie, help support SPL_OF_CONTROL)
> if someone can get me a board.  The general trend is to try and

Sure, working on getting a board!

> support these newer DM functions and remove the old legacy code
> functions.

A lot of modernization of DA850 support has been due to your attention
on the EVM. Its much appreciated :)

Regards,
Sekhar