[U-Boot] [PATCH v2 3/4] dm: net: macb: Implement link speed change callback

Auer, Lukas lukas.auer at aisec.fraunhofer.de
Mon May 27 08:28:46 UTC 2019


On Wed, 2019-05-22 at 00:09 -0700, Bin Meng wrote:
> At present the link speed change callback is a nop. According to
> macb device tree bindings, an optional "tx_clk" is used to clock
> the ethernet controller's TX_CLK under different link speed.
> 
> In 10/100 MII mode, transmit logic must be clocked from a free
> running clock generated by the external PHY. In gigabit GMII mode,
> the controller, not the external PHY, must generate the 125 MHz
> transmit clock towards the PHY.
> 
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> 
> ---
> 
> Changes in v2:
> - add a comment for getting "tx_clk" via clk_get_by_name()
> - does not change anything in the default case
> - check the return value of clk_set_rate()
> 
>  drivers/net/macb.c | 35 +++++++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
> 

Successfully tested the series on a SiFive HiFive Unleashed board at
1000, 100, and 10 Mbps link rates.

Reviewed-by: Lukas Auer <lukas.auer at aisec.fraunhofer.de>
Tested-by: Lukas Auer <lukas.auer at aisec.fraunhofer.de>


More information about the U-Boot mailing list