[U-Boot] [PATCH v3] spl: add overall SPL size check

Simon Goldschmidt simon.k.r.goldschmidt at gmail.com
Mon May 27 19:28:44 UTC 2019


Am 27.05.2019 um 18:48 schrieb Tom Rini:
> On Tue, May 28, 2019 at 01:35:52AM +0900, Masahiro Yamada wrote:
>> On Sat, May 25, 2019 at 5:07 AM Simon Goldschmidt
>> <simon.k.r.goldschmidt at gmail.com> wrote:
>>>
>>> This adds a size check for SPL that can dynamically check generated
>>> SPL binaries (including devicetree) for a size limit that ensures
>>> this image plus global data, heap and stack fit in initial SRAM.
>>>
>>> Since some of these sizes are not available to make, a new host tool
>>> 'spl_size_limit' is added that dumps the resulting maximum size for
>>> an SPL binary to stdout. This tool is used in toplevel Makefile to
>>> implement the size check on SPL binaries.
>>>
>>> Signed-off-by: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
>>> ---
>>
>> Some architectures have SPL size checks.
>> CONFIG_SPL_MAX_FOOTPRINT
>> CONFIG_SPL_MAX_SIZE
>> CONFIG_SPL_BSS_MAX_SIZE
>>
>> Will they be replaced by this new mechanism?
> 
> Yes, as the existing checks are only sufficient for final link time
> overflows and not final image overflows.

This patch builds on Heinrich Schuchardt's series that add 
CONFIG_SPL_SIZE_LIMIT to check maximum image size (after potentially 
adding image headers):

https://patchwork.ozlabs.org/patch/1074741/

I just now realize I have forgotton to add that dependency to the patch 
mail.

However, we do have numerous max size defines. This patch tries to bring 
a better calculation for the maximum SPL image size by taking SRAM size 
and subtracting what's required in addition to the binary size.

In general, the different max size defines could need a cleanup as well, 
I guess...

Regards,
Simon


More information about the U-Boot mailing list