[U-Boot] [PATCH v2 1/2] power: pmic: palmas/lp87565/lp873x: Remove $SPL from Makefile

[keerthy]

On 5/30/2019 10:44 PM, Tom Rini wrote:
> On Thu, May 30, 2019 at 09:58:27AM +0530, Keerthy wrote:
>> Remove $SPL from Makefile as the corresponding SPL config options
>> are not present. This enables them at SPL.
>>
>> Signed-off-by: Keerthy <j-keerthy at ti.com>
>> ---
>>   drivers/power/pmic/Makefile | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/power/pmic/Makefile b/drivers/power/pmic/Makefile
>> index ce250cb155..566cc1f5a6 100644
>> --- a/drivers/power/pmic/Makefile
>> +++ b/drivers/power/pmic/Makefile
>> @@ -20,9 +20,9 @@ obj-$(CONFIG_PMIC_RN5T567) += rn5t567.o
>>   obj-$(CONFIG_PMIC_TPS65090) += tps65090.o
>>   obj-$(CONFIG_PMIC_S5M8767) += s5m8767.o
>>   obj-$(CONFIG_DM_PMIC_TPS65910) += pmic_tps65910_dm.o
>> -obj-$(CONFIG_$(SPL_)PMIC_PALMAS) += palmas.o
>> -obj-$(CONFIG_$(SPL_)PMIC_LP873X) += lp873x.o
>> -obj-$(CONFIG_$(SPL_)PMIC_LP87565) += lp87565.o
>> +obj-$(CONFIG_PMIC_PALMAS) += palmas.o
>> +obj-$(CONFIG_PMIC_LP873X) += lp873x.o
>> +obj-$(CONFIG_PMIC_LP87565) += lp87565.o
>>   obj-$(CONFIG_PMIC_STPMIC1) += stpmic1.o
>>   
>>   obj-$(CONFIG_POWER_LTC3676) += pmic_ltc3676.o
> 
> This comment applies to both 1/2 and 2/2, and is much more obvious with
> 2/2.  Why is this the right approach rather than adding SPL symbols for
> the parts in question?  We have a whole lot of "I am concerned about SPL
> size" posts.  Especially on 2/2 some of the drivers in question aren't
> even things used on TI parts and do (or are shown in the patch context
> to be) use, apparently, the SPL symbol.  Thanks!
> 

lp873x is used with DRA71 and LP87565 is used with DRA76.

We want them to be enabled at SPL level in dra7xx_evm_defconfig but
if due to SPL size constraints if we want control over not enabling
them in SPL then i will send next version with SPL_ defined in their
respective KConfigs.

Thanks,
Keerthy