[U-Boot] [PATCH v4 3/8] pico-imx7d: Correct uart clock root

Jun Nie jun.nie at linaro.org
Fri May 31 03:26:10 UTC 2019


Fabio Estevam <festevam at gmail.com> 于2019年5月31日周五 上午7:56写道:
>
> On Wed, May 8, 2019 at 3:39 AM Jun Nie <jun.nie at linaro.org> wrote:
>
> > +#if (CONFIG_CONS_INDEX == 0)
> > +#define UART_CLK_ROOT UART1_CLK_ROOT
> > +#elif (CONFIG_CONS_INDEX == 1)
> > +#define UART_CLK_ROOT UART2_CLK_ROOT
> > +#elif (CONFIG_CONS_INDEX == 2)
> > +#define UART_CLK_ROOT UART3_CLK_ROOT
> > +#elif (CONFIG_CONS_INDEX == 3)
> > +#define UART_CLK_ROOT UART4_CLK_ROOT
> > +#elif (CONFIG_CONS_INDEX == 4)
> > +#define UART_CLK_ROOT UART5_CLK_ROOT
> > +#elif (CONFIG_CONS_INDEX == 5)
> > +#define UART_CLK_ROOT UART6_CLK_ROOT
> > +#elif (CONFIG_CONS_INDEX == 6)
> > +#define UART_CLK_ROOT UART7_CLK_ROOT
>
> I remember I commented about this before: this looks ugly.
>
> We don't do this on other i.MX devices.

I thought this can be removed if dts is enabled, but no actually. I
will find another solution for this. Thanks!


More information about the U-Boot mailing list