[U-Boot] [PATCH] buildman: Fix problem with non-existent output directories

Bin Meng bmeng.cn at gmail.com
Sat Nov 2 03:54:44 UTC 2019


On Sat, Nov 2, 2019 at 5:48 AM Tom Rini <trini at konsulko.com> wrote:
>
> Now that we have buildman telling genboards.cfg to use an output
> directory we need to ensure that it exists.
>
> Cc: Bin Meng <bmeng.cn at gmail.com>
> Cc: Simon Glass <sjg at chromium.org>
> Fixes: bc750bca1246 ("tools: buildman: Honor output directory when generating boards.cfg")
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
>  tools/buildman/control.py | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/tools/buildman/control.py b/tools/buildman/control.py
> index 9787b8674761..5988ada72b75 100644
> --- a/tools/buildman/control.py
> +++ b/tools/buildman/control.py
> @@ -201,6 +201,8 @@ def DoBuildman(options, args, toolchains=None, make_func=None, boards=None,
>
>      # Work out what subset of the boards we are building
>      if not boards:
> +        if not os.path.exists(options.output_dir):
> +            os.mkdir(options.output_dir)

Use os.makedirs() ?

>          board_file = os.path.join(options.output_dir, 'boards.cfg')
>          genboardscfg = os.path.join(options.git, 'tools/genboardscfg.py')
>          status = subprocess.call([genboardscfg, '-o', board_file])
> --

Regards,
Bin


More information about the U-Boot mailing list