[U-Boot] [PATCH 1/1] ARM: i.MX6: TARGET_NITROGEN6X: add 'select MX6QDL'

[Stefano Babic]

On 26/09/19 18:18, Troy Kisky wrote:
> On 9/25/2019 5:30 PM, Troy Kisky wrote:
>> This fixes commit <91435cd40d30> "ARM: i.MX6: exclude the ARM errata
>>  from i.MX6 UP system"
>>
>> for nitrogen6x. The above commit removed the errata for the board
>> since MX6Q/MXDL/MX6S is selected via CONFIG_SYS_EXTRA_OPTIONS
>>
>> This restores the errata configs.
>>
>> Signed-off-by: Troy Kisky <troy.kisky at boundarydevices.com>
>>
>> ---
>> Note:
>> marsboard, mx6qarm2, seem to have same problem.
>> ---
>>  arch/arm/mach-imx/mx6/Kconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/mx6/Kconfig b/arch/arm/mach-imx/mx6/Kconfig
>> index 01f0121beb..2c2edaa093 100644
>> --- a/arch/arm/mach-imx/mx6/Kconfig
>> +++ b/arch/arm/mach-imx/mx6/Kconfig
>> @@ -412,6 +412,7 @@ config TARGET_NITROGEN6X
>>  	imply USB_ETHER_MCS7830
>>  	imply USB_ETHER_SMSC95XX
>>  	imply USB_HOST_ETHER
>> +	select MX6QDL
>>  
>>  config TARGET_OPOS6ULDEV
>>  	bool "Armadeus OPOS6ULDev board"
>>
> 
> 
> Maybe the more correct fix is to allow MX6Q/MX6DL/MX6S to be selected in the defconfig (add a text
> string in the Kconfig). That way MX6S boards won't have unneeded errata applied.

Not sure. This is really that cannot be configured. If a board has just
a i.MX6DL, well, it should not simply configured via menuconfig. It is
bound with the hardware.

By the way, this simple patch breaks all nitrogen boards, I have to
reject it.

Regards,
Stefano
> 
> Thoughts?
> 
> Troy
> 


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================