[U-Boot] [RFC PATCH 5/5] Add support for the NXP IMXRT1050-EVK board

Giulio Benetti giulio.benetti at benettiengineering.com
Mon Nov 4 16:28:27 UTC 2019


Hi Fabio,

On 11/1/19 1:40 PM, Fabio Estevam wrote:
> Hi Giulio,
> 
> On Wed, Oct 30, 2019 at 6:09 PM Giulio Benetti
> <giulio.benetti at benettiengineering.com> wrote:
> 
> Please add a commit log that briefly describes the board.

Yes.

>>
>> Signed-off-by: Giulio Benetti <giulio.benetti at benettiengineering.com>
>> ---
>>   arch/arm/dts/Makefile                         |   2 +
>>   arch/arm/dts/imxrt1050-evk.dts                | 124 ++++++++
>>   arch/arm/dts/imxrt1050.dtsi                   |  73 +++++
>>   arch/arm/mach-imx/imxrt/Kconfig               |  11 +
>>   board/freescale/imxrt1050-evk/Kconfig         |  19 ++
>>   board/freescale/imxrt1050-evk/MAINTAINERS     |   6 +
>>   board/freescale/imxrt1050-evk/Makefile        |   6 +
> 
> Please add a board/freescale/imxrt1050-evk/README that explains how to
> build, flash the U-Boot binary and boot.

Right.

>>   board/freescale/imxrt1050-evk/imxrt1050-evk.c |  94 ++++++
>>   configs/imxrt1050-evk_defconfig               |  52 ++++
>>   include/configs/imxrt1050-evk.h               |  68 +++++
>>   include/dt-bindings/clock/imxrt-clock.h       | 272 ++++++++++++++++++
>>   11 files changed, 727 insertions(+)
>>   create mode 100644 arch/arm/dts/imxrt1050-evk.dts
>>   create mode 100644 arch/arm/dts/imxrt1050.dtsi
>>   create mode 100644 board/freescale/imxrt1050-evk/Kconfig
>>   create mode 100644 board/freescale/imxrt1050-evk/MAINTAINERS
>>   create mode 100644 board/freescale/imxrt1050-evk/Makefile
>>   create mode 100644 board/freescale/imxrt1050-evk/imxrt1050-evk.c
>>   create mode 100644 configs/imxrt1050-evk_defconfig
>>   create mode 100644 include/configs/imxrt1050-evk.h
>>   create mode 100644 include/dt-bindings/clock/imxrt-clock.h
> 
> This imxrt-clock.h header and the arch/arm/dts/imxrt1050.dts  is
> common imxrt code and not related to the evk board, so better put them
> on a separate patch.

Ok, already done since I'm working right on clock driver now.

Thanks for reviewing my patches, can you also take a look at this [1]?
Because I don't know how to proceed with sdram driver.

Thanks in advance

[1]: https://lists.denx.de/pipermail/u-boot/2019-October/388905.html

Best regards
-- 
Giulio Benetti
Benetti Engineering sas


More information about the U-Boot mailing list