[U-Boot] [PATCH v1 2/4] dm: board: complete the initialization of the muxes in initr_dm()

Jean-Jacques Hiblot jjhiblot at ti.com
Mon Nov 4 18:07:21 UTC 2019


On 30/10/2019 02:48, Simon Glass wrote:
> Hi Jean-Jacques,
>
> On Wed, 2 Oct 2019 at 06:47, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
>> This will probe the multiplexer devices that have a "u-boot,mux-autoprobe"
>> property. As a consequence they will be put in their idle state.
>>
>> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
>> ---
>>
>>   common/board_r.c | 2 ++
>>   1 file changed, 2 insertions(+)
> I worry this should happen later, or lazily, since at present we don't
> actually probe any devices at this point, right?

It has to be done early to make sure that the platform is in the right 
state before most of the drivers are initialized. Some devices may rely 
on it without knowing it. In this way, it is similar to the gpio-hog 
mechanism.

Now, I have no strong opinion on when this should really take place. 
Only it has to be after dm is initialized. Maybe it could be inserted in 
init_sequence_r, after board_init() ?

It should probably be before the serial port is used, just in case 
someone multiplexed the serial port of the console.


JJ


>
> Regards,
> Simon
>


More information about the U-Boot mailing list