[U-Boot] [RFC PATCH] dm: core: Remove libfdt dependency when unnecessary

Ezequiel Garcia ezequiel at vanguardiasur.com.ar
Tue Nov 5 16:56:00 UTC 2019

Hello Walter,

Thanks for the patch.

On Tue, 5 Nov 2019 at 12:27, Walter Lozano <walter.lozano at collabora.com> wrote:
> The support of libfdt should only be needed when OF_CONTROL
> is enabled and OF_PLATDATA is not, as in other cases there is no
> DT file to query.
> This patch fixes this dependency allowing to save some space.

Can you add some more information about the space saving?
The ./scripts/bloat-o-meter will help you get some info
on static footprint.

> Signed-off-by: Walter Lozano <walter.lozano at collabora.com>
> ---
>  drivers/core/ofnode.c | 132 +++++++++++++++++++++++++++++++++++++--
>  include/dm/read.h     | 141 ++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 267 insertions(+), 6 deletions(-)

You should try to avoid adding #ifdefery to the code. Normally,
the way to ifdef code is by having this in a header:

int foo_feature_optional(struct foo *priv);
static inline int foo_feature_optional(struct foo *priv)
        return 0;

The user of foo_feature_optional shouldn't be bothered with
FOO being enabled or not. Pushing ifdefs away from .c to .h
is a common pattern, well described in a classic old article:


Do you think you can try to rework the patch to reduce its impact
as much as possible?


More information about the U-Boot mailing list