[U-Boot] [PATCH 1/1] hush: re-sequence includes

Tom Rini trini at konsulko.com
Fri Nov 8 15:33:04 UTC 2019


On Sat, Oct 26, 2019 at 11:45:08PM +0200, Heinrich Schuchardt wrote:

> 'make tests' on a 32bit ARM system leads to
> 
> In file included from ../common/cli_hush.c:79:
> ../include/malloc.h:364:7: error: conflicting types for ‘memset’
>  void* memset(void*, int, size_t);
>        ^~~~~~
> In file included from ../include/compiler.h:126,
>                  from ../include/env.h:12,
>                  from ../common/cli_hush.c:78:
> ../include/linux/string.h:103:15:
> note: previous declaration of ‘memset’ was here
>  extern void * memset(void *,int,__kernel_size_t);
>                ^~~~~~
> In file included from ../common/cli_hush.c:79:
> ../include/malloc.h:365:7: error: conflicting types for ‘memcpy’
>  void* memcpy(void*, const void*, size_t);
>        ^~~~~~
> In file included from ../include/compiler.h:126,
>                  from ../include/env.h:12,
>                  from ../common/cli_hush.c:78:
> ../include/linux/string.h:106:15:
> note: previous declaration of ‘memcpy’ was here
>  extern void * memcpy(void *,const void *,__kernel_size_t);
>         ^~~~~~
> 
> According to the U-Boot coding style guide common.h should be the first
> include.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191108/aeba59a0/attachment.sig>


More information about the U-Boot mailing list