[U-Boot] Pull request: u-boot-rockchip-20191026

[Tom Rini]

On Fri, Nov 08, 2019 at 10:14:45AM +0800, Kever Yang wrote:

> Hi Tom,
> 
> Please pull the rockchip update:
> - Add support for rockchip pmic rk805,rk809, rk816, rk817
> - Add rk3399 board Leez support
> - Fix bug in rk3328 ram driver
> - Adapt SPL to support ATF bl31 with entry at 0x40000
> 
> Fix the u8 type comparision with '-1'.
> 
> Travis:
> https://travis-ci.org/keveryang/u-boot/builds/608622183
> 
> Thanks,
> - Kever
> 
> The following changes since commit 0f282c1876af26cc2c8c018ae6293a691561011e:
> 
>   Makefile: fix dependency for imx targets (2019-11-06 09:22:32 -0500)
> 
> are available in the Git repository at:
> 
>   https://gitlab.denx.de/u-boot/custodians/u-boot-rockchip.git tags/u-boot-rockchip-20191108
> 
> for you to fetch changes up to 08d9fe749237267bc60188fe116eb2f4ae0b18e7:
> 
>   rockchip: firefly-rk3288: Enable TPL support (2019-11-07 16:39:57 +0800)
> 

Having just told Wolfgang that I pay attention to checkpatch messages
about whitespace, I'm going to ask you to fix some things in your PR.
Passing it though ./scripts/checkpatch.pl --git will help you in the
future.  There's a number of files where you're adding extra whitespace
such as:
CHECK: Please don't use multiple blank lines
#223: FILE: drivers/power/regulator/rk8xx.c:373:

+

total: 0 errors, 1 warnings, 1 checks, 264 lines checked

And you should also fix things like:
WARNING: email address 'Kever Yang<kever.yang at rock-chips.com>' might be better as 'Kever Yang <kever.yang at rock-chips.com>'
#13:
Reviewed-by: Kever Yang<kever.yang at rock-chips.com>

Finally and more seriously:
CHECK: Macro argument 'n' may be better as '(n)' to avoid precedence
issues
#143: FILE: drivers/power/regulator/rk8xx.c:31:
+#define RK817_BUCK_ON_VSEL(n)          (0xbb + 3 * (n - 1))

in a whole lot of places.  Please address them all, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191108/8f402ff8/attachment.sig>