[U-Boot] [PATCH v2 32/41] common: Move interrupt functions into a new header

Tom Rini trini at konsulko.com
Tue Nov 12 14:13:44 UTC 2019


On Tue, Nov 12, 2019 at 07:10:29AM -0700, Simon Glass wrote:
> Hi Tom,
> 
> On Mon, 11 Nov 2019 at 07:51, Tom Rini <trini at konsulko.com> wrote:
> >
> > On Fri, Nov 08, 2019 at 12:53:39PM -0700, Simon Glass wrote:
> >
> > > These functions do not use driver model but are fairly widely used in
> > > U-Boot. Move them to a new irq_legacy.h header file.
> > >
> > > Signed-off-by: Simon Glass <sjg at chromium.org>
> >
> > I'm still weighing what I want to say about cpu_legacy.h but I feel like
> > for irq_legancy.h we're getting ahead of ourselves.  What is the DM
> > model for this?  Why do we need it?  I didn't dig in to every function
> > but it looks like we have a mix of U-Boot ABI functions and exception
> > handlers.  That stuff must be very lean.  Thanks!
> 
> Yes fair enough.
> 
> We have had an IRQ uclass for a while but it is not widely used (just
> on x86 and only for probing). I don't want to call this irq.h since it
> is so common, so I'll rename to irq_funcs.h I think.

Works for me, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20191112/9aefb6dc/attachment.sig>


More information about the U-Boot mailing list