[U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE

Priyanka Jain priyanka.jain at nxp.com
Wed Nov 13 03:54:49 UTC 2019



>-----Original Message-----
>From: Michael Walle <michael at walle.cc>
>Sent: Tuesday, November 12, 2019 2:20 PM
>To: Priyanka Jain <priyanka.jain at nxp.com>
>Cc: u-boot at lists.denx.de; Tom Rini <trini at konsulko.com>
>Subject: Re: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE
>
>Am 2019-11-11 16:20, schrieb Priyanka Jain:
>>> -----Original Message-----
>>> From: U-Boot <u-boot-bounces at lists.denx.de> On Behalf Of Michael
>>> Walle
>>> Sent: Monday, October 21, 2019 11:04 PM
>>> To: u-boot at lists.denx.de
>>> Cc: Tom Rini <trini at konsulko.com>
>>> Subject: [U-Boot] [PATCH] armv8: layerscape: set HWCONFIG_BUFFER_SIZE
>>>
>>> Set the HWCONFIG_BUFFER_SIZE if it is not already set. Otherwise
>>> compilation will fail if CONFIG_HWCONFIG and HWCONFIG_BUFFER_SIZE
>are
>>> not set.
>>>
>>> Taken from arch/powerpc/include/asm/config.h.
>>>
>>> Signed-off-by: Michael Walle <michael at walle.cc>
>>> ---
>>
>> Applied to fsl-qoriq master, awaiting upstream.
>
>That one wasn't applied, was it? You said this patch breaks other boards. For
>now, I just had time to had a brief look at it. Seems like the culprit is that the
>configs/bla_common.h for the these boards include <asm/arch/config.h>,
>although will be included later in include/config.h. So it is not possible to
>provide "defaults" for any macros. Do you think it is possible to remove the
>"#include <asm/arch/config.h>" in your _common.h config files?
>
>-michael
Yes you are right. I dropped this patch at the last moment.
Sorry for confusion. 
Regarding dropping "#include <asm/arch/config.h>" in your _common.h config files
This wont be simple. Can you please think of alternative way.

-priyankajain



More information about the U-Boot mailing list