[U-Boot] [PATCH v3 01/42] common: Move legacy CPU functions to their own header

Simon Glass sjg at chromium.org
Thu Nov 14 13:44:52 UTC 2019


Hi Tom,

On Wed, 13 Nov 2019 at 09:07, Tom Rini <trini at konsulko.com> wrote:
>
> On Tue, Nov 12, 2019 at 12:42:10PM -0700, Simon Glass wrote:
>
> > These should be moved to driver model, but in the meantime, move them
> > out of the common header to help reduce its size.
> >
> > Signed-off-by: Simon Glass <sjg at chromium.org>
> > ---
> >
> > Changes in v3: None
> > Changes in v2: None
>
> I was hoping to get back to this part before you did a v3, sorry.  I
> guess my reaction at this point is that much like how v2->v3 did
> irq_legacy.h -> irq_funcs.h we should also do cpu_legacy.h ->
> cpu_funcs.h (or some other name).  There's I suspect a good argument to
> say that yes, some of these functions should be moved to DM (or,
> platforms age out) and some do not.  Thanks!

Thanks for the guidance, sounds good. I will update this and hopefully
send v4 by tomorrow morning.

Regards,
Simon


More information about the U-Boot mailing list