[U-Boot] [PATCH v4 31/42] common: Move ARM cache operations out of common.h

Simon Glass sjg at chromium.org
Fri Nov 15 16:46:21 UTC 2019


Hi Daniel,

inOn Fri, 15 Nov 2019 at 05:48, Daniel Schwierzeck
<daniel.schwierzeck at gmail.com> wrote:
>
[..]

> > diff --git a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> > index 7eb632d3b1..e9e18568c1 100644
> > --- a/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> > +++ b/drivers/usb/gadget/dwc2_udc_otg_xfer_dma.c
> > @@ -17,6 +17,9 @@
> >   * Lukasz Majewski <l.majewski at samsumg.com>
> >   */
> >
> > +#include <common.h>
> > +#include <cpu_func.h>
> > +
>
> is this intended if both files haven't been required before?

Well common.h should always be included. The second is needed since
flush_dcache_range() is called. This file would cause a error if it
were compiled. It seems to be excluded from the build.

>
> >  static u8 clear_feature_num;
> >  int clear_feature_flag;
> >

Regards,
Simon


More information about the U-Boot mailing list