[U-Boot] [PATCH 1/4] arm64: dts: rk3399-rock960: add vdd_log and its init value

Kever Yang kever.yang at rock-chips.com
Sun Nov 17 07:57:31 UTC 2019


Hi Peter,

On 2019/11/15 下午9:17, Peter Robinson wrote:
> On Wed, Nov 13, 2019 at 3:14 AM Kever Yang <kever.yang at rock-chips.com> wrote:
>> Add vdd_log node according to rock960 schematic V13.
>> This patch affect two boards:
>> - Rock960 Model A
>> - Ficus
>>
>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
> Is there a reason this is getting added to the -u-boot.dtsi vs the
> base .dtsi? I did see a patch for the Linux dtsi to do similar so
> presumably once there's a v2 of that to fix the minor issue there it
> would basically be the same patch for U-Boot or a sync of the Linux
> dts to U-Boot.

The "regulator-init-microvolt" is only available at U-Boot and not at 
kernel, so it may not able

to add this property into kernel directly, so I prefer to fix this in 
U-Boot because this is a bug and

should be fixed soon instead of everything is done in kernel.


Thanks,

- Kever

>
> Peter
>
>> ---
>>
>>   arch/arm/dts/rk3399-rock960-u-boot.dtsi | 13 +++++++++++++
>>   1 file changed, 13 insertions(+)
>>
>> diff --git a/arch/arm/dts/rk3399-rock960-u-boot.dtsi b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> index 4850debdf0..82f2c311af 100644
>> --- a/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> +++ b/arch/arm/dts/rk3399-rock960-u-boot.dtsi
>> @@ -10,4 +10,17 @@
>>          chosen {
>>                  u-boot,spl-boot-order = &sdhci, &sdmmc;
>>          };
>> +
>> +       vdd_log: vdd-log {
>> +               compatible = "pwm-regulator";
>> +               pwms = <&pwm2 0 25000 1>;
>> +               regulator-name = "vdd_log";
>> +               regulator-always-on;
>> +               regulator-boot-on;
>> +               regulator-min-microvolt = <800000>;
>> +               regulator-max-microvolt = <1400000>;
>> +               regulator-init-microvolt = <950000>;
>> +               vin-supply = <&vcc5v0_sys>;
>> +       };
>> +
>>   };
>> --
>> 2.17.1
>>




More information about the U-Boot mailing list