[U-Boot] [PATCH v4 4/5] doc: bindings: add mdio-handle property to ethernet nodes

Grygorii Strashko grygorii.strashko at ti.com
Mon Nov 18 19:11:41 UTC 2019

On 14/11/2019 17:04, Alex Marginean wrote:
> Adds an optional mdio-handle property which identifies a MDIO bus which can
> be scanned to find the relevant PHY.  The property is ignored if phy-handle
> is also present.
> Signed-off-by: Alex Marginean <alexandru.marginean at nxp.com>
> ---
>   doc/device-tree-bindings/net/ethernet.txt | 2 ++
>   1 file changed, 2 insertions(+)
> diff --git a/doc/device-tree-bindings/net/ethernet.txt b/doc/device-tree-bindings/net/ethernet.txt
> index 3fc360523b..9f9629f8d6 100644
> --- a/doc/device-tree-bindings/net/ethernet.txt
> +++ b/doc/device-tree-bindings/net/ethernet.txt
> @@ -9,6 +9,8 @@ The following properties are common to the Ethernet controllers:
>   - max-speed: number, specifies maximum speed in Mbit/s supported by the device;
>   - max-frame-size: number, maximum transfer unit (IEEE defined MTU), rather than
>     the maximum frame size (there's contradiction in ePAPR).
> +- mdio-handle: phandle, specifies a reference to a MDIO bus to be scanned to
> +  find the PHY device.  Ignored if phy-handle is also present.

Sry, but it looks redundant. The Ethernet-controller bindings
expects to use phy-handle which, in turn, allows to get MDIO node.

So, if your platform is DT based and can use DT then it's reasonable to follow standard binding,
which, in addition, allows to specify Ethernet PHY properties.
More over, your series does not provide user for this new property.

Personally I do not see even reasons to have doc/device-tree-bindings/net/ethernet.txt in u-boot
and think we should follow [1]

>   - phy-mode: string, operation mode of the PHY interface; supported values are
>     "mii", "gmii", "sgmii", "qsgmii", "tbi", "rev-mii", "rmii", "rgmii", "rgmii-id",
>     "rgmii-rxid", "rgmii-txid", "rtbi", "smii", "xgmii"; this is now a de-facto

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/net/ethernet-controller.yaml

Best regards,

More information about the U-Boot mailing list