[U-Boot] [PATCH v3 077/108] spi: ich: Move the protection/lockdown code into a function

Bin Meng bmeng.cn at gmail.com
Tue Nov 19 13:53:03 UTC 2019


Hi Simon,

On Mon, Oct 21, 2019 at 11:40 AM Simon Glass <sjg at chromium.org> wrote:
>
> Reduce the size of the probe function but putting this code into its own
> function.
>

It's unclear to me why this brings any benefit? The size of the probe
function indeed is reduced, but whole file size does not change, no?

> Also remove the assumption that the PCH is always a parent of the SPI
> controller, as this is not the case APL platforms. Use driver model to
> find the PCH instead.
>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v3: None
> Changes in v2: None
>
>  drivers/spi/ich.c | 55 +++++++++++++++++++++++++++++++----------------
>  drivers/spi/ich.h |  1 +
>  2 files changed, 38 insertions(+), 18 deletions(-)
>

Regards,
Bin


More information about the U-Boot mailing list