[U-Boot] [PATCH v6 17/19] arm: dts: agilex: Add base dtsi and devkit dts

[Simon Goldschmidt]

Am 19.11.2019 um 16:10 schrieb Marek Vasut:
> On 11/19/19 4:27 AM, Ley Foon Tan wrote:
>> On Thu, Nov 14, 2019 at 3:46 AM Simon Goldschmidt
>> <simon.k.r.goldschmidt at gmail.com> wrote:
>>>
>>> Am 08.11.2019 um 05:11 schrieb Ley Foon Tan:
>>>> Add device tree files for Agilex SoC platform.
>>>>
>>>> Based on Linux Commit ID      4b36daf9ada30.
>>>
>>> Based on? Why is this not a copy of the Linux devicetree files? The
>>> single difference should be in *-u-boot.dtsi. Being like this, I don't
>>> know what good it is to add the Linux commit ID if the files are
>>> obviously different... :-(
>> Some dts properties are missing in Linux dts. E.g:
>> - The clock dts information is not upstreamed in Linux yet.
>> - CCU node is not in Linux dts (Linux doesn't need to initialize CCU)
>> - Compatible string for rstmgr is different in Linux and Uboot.
>>
>> So, there are some differences in Linux vs Uboot dts/dtsi.
>> I can remove Linux commit ID in commit message if it is confusing.
> 
> Or maybe you can pull the extras into socfpga_agilex-u-boot.dtsi and
> keep the socfpga_agilex.dtsi as it is from Linux ?
> 

That would be my preference as well.

A devicetree should describe the hardware, so all devicetrees for a 
single hardware should be the same everywhere (U-Boot, Linux or other 
OS). Unless this is the case, describing the difference in a U-Boot 
specific addon file seems like the best documentation of such differences.

And even if you don't do that: if you reference a commit ID from Linux, 
you should actually describe the difference. That is done best by having 
separate patches or separate files (the -u-boot.dtsi is clearly not from 
Linux), but at least write it in the commit message.


Regards,
Simon