[U-Boot] [EXT] Re: [RFC PATCH 13/29] arch: include: octeontx: add headers for OcteonTX

[Aaron Williams]

Hi Simon,

On Tuesday, November 19, 2019 7:00:23 PM PST Simon Glass wrote:
> External Email
> 
> ----------------------------------------------------------------------
> Hi,
> 
> On Tue, 29 Oct 2019 at 14:08, Suneel Garapati <suneelglinux at gmail.com> 
wrote:
> > From: Suneel Garapati <sgarapati at marvell.com>
> > 
> > Signed-off-by: Suneel Garapati <sgarapati at marvell.com>
> > ---
> > 
> >  arch/arm/include/asm/arch-octeontx/board.h    |  121 ++
> >  arch/arm/include/asm/arch-octeontx/clock.h    |   25 +
> >  .../asm/arch-octeontx/csrs/csrs-mio_emm.h     | 1193 +++++++++++++++++
> >  .../include/asm/arch-octeontx/csrs/csrs-xcv.h |  428 ++++++
> >  arch/arm/include/asm/arch-octeontx/gpio.h     |    6 +
> >  arch/arm/include/asm/arch-octeontx/smc.h      |   20 +
> >  arch/arm/include/asm/arch-octeontx/soc.h      |   31 +
> >  7 files changed, 1824 insertions(+)
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/board.h
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/clock.h
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/csrs/csrs-mio_emm.h
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/csrs/csrs-xcv.h
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/gpio.h
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/smc.h
> >  create mode 100644 arch/arm/include/asm/arch-octeontx/soc.h
> 
> I think we try to avoid bitfields, but I'm not sure if there is a
> rule, and this is arch-specific code.

These bitfields are arch specific and often are created by scripts directly 
from the hardware definitions. We specifically strip out the comments in our 
register bitfields because otherwise the files would be huge. What would 
normally be in the comments would match what is in our hardware reference 
manual.

> 
> +Tom Rini who will know
> 
> Please remember to comment your structs and members.
> 
> Regards,
> SImon

Regards,

Aaron