[U-Boot] [PATCH] power: fan53555: fix fan53555_regulator_set_value

Kever Yang kever.yang at rock-chips.com
Wed Nov 20 07:10:18 UTC 2019


On 2019/11/18 上午2:47, Vasily Khoruzhick wrote:
> fan53555_regulator_set_value() passes its own dev to pmic_clrsetbits()
> instead of its parent (pmic). As result u-boot crashes when you try to
> set voltage on fan53555 regulator
>
> Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>

Reviewed-by: Kever Yang <kever.yang at rock-chips.com>

Thanks,
- Kever
> ---
>   drivers/power/regulator/fan53555.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/power/regulator/fan53555.c b/drivers/power/regulator/fan53555.c
> index 9c48b26216..24a9b67586 100644
> --- a/drivers/power/regulator/fan53555.c
> +++ b/drivers/power/regulator/fan53555.c
> @@ -159,7 +159,7 @@ static int fan53555_regulator_set_value(struct udevice *dev, int uV)
>   	debug("%s: uV=%d; writing volume %d: %02x\n",
>   	      __func__, uV, pdata->vol_reg, vol);
>   
> -	return pmic_clrsetbits(dev, pdata->vol_reg, GENMASK(6, 0), vol);
> +	return pmic_clrsetbits(dev->parent, pdata->vol_reg, GENMASK(6, 0), vol);
>   }
>   
>   static int fan53555_voltages_setup(struct udevice *dev)




More information about the U-Boot mailing list