[U-Boot] [PATCH] arm: socfpga: add kernel parameter for immediate reboot

[Nguyen, Dinh]

> -----Original Message-----
> From: Simon Goldschmidt <simon.k.r.goldschmidt at gmail.com>
> Sent: Thursday, November 21, 2019 9:28 AM
> To: Ooi, Joyce <joyce.ooi at intel.com>
> Cc: See, Chin Liang <chin.liang.see at intel.com>; Nguyen, Dinh
> <dinh.nguyen at intel.com>; U-Boot Mailing List <u-boot at lists.denx.de>; Ang,
> Chee Hong <chee.hong.ang at intel.com>
> Subject: Re: [U-Boot] [PATCH] arm: socfpga: add kernel parameter for
> immediate reboot
> 
> On Thu, Nov 21, 2019 at 4:10 PM Ooi, Joyce <joyce.ooi at intel.com> wrote:
> >
> > Add Linux kernel line parameters for Stratix10 U-Boot.
> > The "panic=-1" indicates the reset should occur immediately (without a
> > delay)
> >
> > Signed-off-by: Thor Thayer <thor.thayer at linux.intel.com>
> > Signed-off-by: Ooi, Joyce <joyce.ooi at intel.com>
> 
> You might want to send socfpga patches to the U-Boot socfpga maintainers as
> well...
> 
> > ---
> >  include/configs/socfpga_stratix10_socdk.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/include/configs/socfpga_stratix10_socdk.h
> > b/include/configs/socfpga_stratix10_socdk.h
> > index 8e6ecf4..09ea066 100644
> > --- a/include/configs/socfpga_stratix10_socdk.h
> > +++ b/include/configs/socfpga_stratix10_socdk.h
> > @@ -88,7 +88,7 @@ unsigned int cm_get_qspi_controller_clk_hz(void);
> >   * CONFIG_BOOTARGS goes into the environment value "bootargs".
> >   * Do note the value will override also the chosen node in FDT blob.
> >   */
> > -#define CONFIG_BOOTARGS "earlycon"
> > +#define CONFIG_BOOTARGS "earlycon panic=-1"
> 
> That looks a bit like a hack. In my opinion, bootargs should be provided by the
> boot configuration (e.g. included in devicetree), not hardcoded in the
> bootloader.
> 
> I'd rather take a patch that removes this line than adding more.

Agreed! Also, what's the reason that you want to force an immediate reboot when a
panic happens?

Dinh