[U-Boot] [PATCH v3] arm: add acpi support for the arm

Steven Hao steven_hao5189 at outlook.com
Mon Nov 25 02:42:19 UTC 2019


Dear Bin:

I have a suggetion that the acpi specification definition such as all acpi table structure definition  should be place in /include directory.
and write_acpi_tables function can be placed in platform directory.  Creating acpi table mothod  can be diffrent between x86 and arm.

Thank you
Steven Hao

获取 Outlook for iOS<https://aka.ms/o0ukef>
________________________________
发件人: Bin Meng <bmeng.cn at gmail.com>
发送时间: Monday, November 25, 2019 10:13:40 AM
收件人: Steven Hao <steven_hao5189 at outlook.com>
抄送: xypron.glpk at gmx.de <xypron.glpk at gmx.de>; liuhao at phytium.com.cn <liuhao at phytium.com.cn>; agraf at csgraf.de <agraf at csgraf.de>; jagan at amarulasolutions.com <jagan at amarulasolutions.com>; marek.vasut at gmail.com <marek.vasut at gmail.com>; sr at denx.de <sr at denx.de>; patrice.chotard at st.com <patrice.chotard at st.com>; afd at ti.com <afd at ti.com>; horatiu.vultur at microchip.com <horatiu.vultur at microchip.com>; narmstrong at baylibre.com <narmstrong at baylibre.com>; ryder.lee at mediatek.com <ryder.lee at mediatek.com>; igor.opaniuk at gmail.com <igor.opaniuk at gmail.com>; patrick.delaunay at st.com <patrick.delaunay at st.com>; eugen.hristev at microchip.com <eugen.hristev at microchip.com>; sjg at chromium.org <sjg at chromium.org>; judge.packham at gmail.com <judge.packham at gmail.com>; yamada.masahiro at socionext.com <yamada.masahiro at socionext.com>; swarren at nvidia.com <swarren at nvidia.com>; michal.simek at xilinx.com <michal.simek at xilinx.com>; u-boot at lists.denx.de <u-boot at lists.denx.de>; Andy Shevchenko <andriy.shevchenko at linux.intel.com>
主题: Re: [PATCH v3] arm: add acpi support for the arm

Hi Steven,

On Mon, Nov 25, 2019 at 10:09 AM Steven Hao <steven_hao5189 at outlook.com> wrote:
>
> Dear Bin:
>
> Firstly:
> I know that acpi about x86 is existing. And it is usefull for x86 platfporm. If it  is used to arm platform,some modification may have to do. For example,facs table is useless for arm.
>
> In adition,The acpi table is writed statically and then modified dynamically in my patch. It is a new method.
>
> I want to consult that whether my method is helpful or not.
>
> Secondly:
> If i want to reuse the x86-acpi. I will overwrite the write_acpi_tables function. But the definition about acpi strcuture is placed in arch/x86/include/asm directory. It can not be used to arm plateform. If the acpi library need to surport for all platform,i think it should move to /include directory.
>

Yes, we all are aware that modifications are needed to the existing
x86 ACPI support to support ARM. We don't want to create 2 ACP
implementation in U-Boot.

Regards,
Bin


More information about the U-Boot mailing list