[U-Boot] [PATCH v5 008/101] i2c: designware: Avoid using static data

Bin Meng bmeng.cn at gmail.com
Mon Nov 25 15:14:26 UTC 2019


Hi Simon,

On Mon, Nov 25, 2019 at 12:11 PM Simon Glass <sjg at chromium.org> wrote:
>
> Drivers are not allowed to use static data since they may be used in SPL
> where BSS is not available.
>
> It is possible that driver model may provide support for numbering devices
> in the future. But for now, move this to global_data.

Can we add such functionality in driver model now? I feel a little bit
odd to add a device number in the global data.

>
> Signed-off-by: Simon Glass <sjg at chromium.org>
> ---
>
> Changes in v5: None
> Changes in v4:
> - Add new patch to drop static data in designware i2c driver
>
> Changes in v3: None
> Changes in v2: None
>
>  arch/x86/include/asm/global_data.h | 1 +
>  drivers/i2c/designware_i2c_pci.c   | 9 ++++++---
>  2 files changed, 7 insertions(+), 3 deletions(-)
>

Regards,
Bin


More information about the U-Boot mailing list