[U-Boot] [PATCH v3 06/16] linux/time.h: include vsprintf.h

Heinrich Schuchardt xypron.glpk at gmx.de
Tue Nov 26 07:31:18 UTC 2019

On 11/26/19 4:56 AM, Heinrich Schuchardt wrote:
> On 11/13/19 1:44 AM, AKASHI Takahiro wrote:
>> Without this commit, time.h possibly causes a build error as
>> asctime_r() uses sprintf().
> asctime_r() is not a Linux symbol (as of next-20191119)
> ctime_r() and asctime_r() are defined as inline functions. ctime_r() is
> used in multiple places and so we may end up duplicating code. So I
> would prefer the inline functions in time.h to be moved to a separate C
> file in lib/.
> Best regards
> Heinrich

Could it be that in one of your C files you simply didn't follow the
U-Boot coding style convention to include common.h first and we don't
need this patch at all?


Best regards


More information about the U-Boot mailing list