[U-Boot] [PATCH v5 012/101] board_r: Move early-timer init later

Simon Glass sjg at chromium.org
Tue Nov 26 17:07:57 UTC 2019


Hi Bin,

On Mon, 25 Nov 2019 at 23:11, Bin Meng <bmeng.cn at gmail.com> wrote:
>
> Hi Simon,
>
> On Mon, Nov 25, 2019 at 12:11 PM Simon Glass <sjg at chromium.org> wrote:
> >
> > At present the early timer init happens as soon as driver mode is set up.
>
> mode -> model
>
> > This makes it impossible to do any in that needs driver model but must run
>
> in -> thing?
>
> > before devices are problem (as needed with Intel's FSP-S, for example).
>
> problem -> probed?
>

Thanks, need to do a better job of proofreading. The series is too big...

[..]

> > diff --git a/drivers/pinctrl/Kconfig b/drivers/pinctrl/Kconfig
> > index eadcfd6652..449f614eb2 100644
> > --- a/drivers/pinctrl/Kconfig
> > +++ b/drivers/pinctrl/Kconfig
> > @@ -82,6 +82,13 @@ config SPL_PINCTRL
> >           This option is an SPL-variant of the PINCTRL option.
> >           See the help of PINCTRL for details.
> >
> > +config TPL_PINCTRL
> > +       bool "Support pin controllers in TPL"
> > +       depends on TPL && TPL_DM
> > +       help
> > +         This option is an TPL variant of the PINCTRL option.
> > +         See the help of PINCTRL for details.
> > +
> >  config SPL_PINCTRL_FULL
> >         bool "Support full pin controllers in SPL"
> >         depends on SPL_PINCTRL && SPL_OF_CONTROL
> > @@ -91,6 +98,13 @@ config SPL_PINCTRL_FULL
> >           This option is an SPL-variant of the PINCTRL_FULL option.
> >           See the help of PINCTRL_FULL for details.
> >
> > +config TPL_PINCTRL_FULL
> > +       bool "Support full pin controllers in TPL"
> > +       depends on TPL_PINCTRL && TPL_OF_CONTROL
> > +       help
> > +         This option is an TPL-variant of the PINCTRL_FULL option.
> > +         See the help of PINCTRL_FULL for details.
> > +
> >  config SPL_PINCTRL_GENERIC
> >         bool "Support generic pin controllers in SPL"
> >         depends on SPL_PINCTRL_FULL
> > --
>
> The above 2 Kconfig changes should not be in this commit.

Yes I'll move them to a separate one.

Regards,
Simon


More information about the U-Boot mailing list