[U-Boot] [PATCH 6/9] phy: atheros: fix delay configuration

Joe Hershberger joe.hershberger at gmail.com
Sat Nov 30 01:17:18 UTC 2019


On Fri, Oct 25, 2019 at 7:30 PM Michael Walle <michael at walle.cc> wrote:
>
> The delay_config() code could only set the delay bit. Thus, it could
> only enable the delay mode, but not disable it. To make things worse,
> the RX delay mode is enabled by default after a hardware reset, so it
> could never be disabled. Fix this, by always setting or clearing the
> bits. This is also how the linux kernel configures the PHY.
>
> If bisecting shows that this commit breaks your board you probably have
> a wrong PHY interface mode. You probably want the
> PHY_INTERFACE_MODE_RGMII_RXID or PHY_INTERFACE_MODE_RGMII_ID mode.
>
> Signed-off-by: Michael Walle <michael at walle.cc>

Either the offending dts's are already updated or they will be when
this breaks them. It's been 6 months.

Acked-by: Joe Hershberger <joe.hershberger at ni.com>


More information about the U-Boot mailing list