[RFC PATCH] powerpc, qe: add DTS support for parallel I/O ports

Heiko Schocher hs at denx.de
Thu Apr 9 07:20:07 CEST 2020


Hello Priyanka,

Am 18.02.2020 um 10:05 schrieb Heiko Schocher:
> add DM support for parallel I/O ports on QUICC Engine Block
> 
> Signed-off-by: Heiko Schocher <hs at denx.de>
> ---
> Travis build:
> 
> https://travis-ci.org/hsdenx/u-boot-test/builds/651400509
> 
> Open questions / discussion:
> 
> - may we should move this part to drivers/pinctrl ?
> 
> - I let the old none DM based implementation in code
>    so boards should work with old implementation.
> 
>    This should be removed if all boards are converted to
>    DM/DTS.
> 
> - Unfortunately linux DTS does not use "pinctrl-"
>    properties, instead "pio-handle" properties.
> 
>    Even worser old U-Boot code initializes all pins
>    defined in "const qe_iop_conf_t qe_iop_conf_tab[]"
>    table in board code. As linux does the same I decided
>    to also scan through all subnodes containing "pio-map"
>    property and initialize them too.
> 
>    The proper solution would be to check for "pio-handle"
>    when a device is probed.
> 
> 
>   arch/powerpc/cpu/mpc83xx/cpu_init.c |   8 ++
>   arch/powerpc/cpu/mpc83xx/qe_io.c    | 193 +++++++++++++++++++++++++++-
>   include/fsl_qe.h                    |   3 +
>   3 files changed, 201 insertions(+), 3 deletions(-)

Any comments?

Thanks!

bye,
Heiko
-- 
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-52   Fax: +49-8142-66989-80   Email: hs at denx.de


More information about the U-Boot mailing list