[PATCH 1/3] mips: mt76x8: ddr_cal: Rename dqs_test_valid() to dqs_test_error()

Weijie Gao weijie.gao at mediatek.com
Wed Apr 15 09:19:44 CEST 2020


On Fri, 2020-03-06 at 15:14 +0100, Stefan Roese wrote:
> This function returns "-1" (true) upon error. So the function name does
> not match its implementation which is confusing. This patch renames the
> function to dqs_test_error() which makes the code easier to read.
> 
> Also change the return type to bool and return "true" or "false".
> 
> Signed-off-by: Stefan Roese <sr at denx.de>
> Cc: Weijie Gao <weijie.gao at mediatek.com>
> Cc: Daniel Schwierzeck <daniel.schwierzeck at gmail.com>
> ---
>  arch/mips/mach-mtmips/ddr_cal.c | 12 ++++++------
>  1 file changed, 6 insertions(+), 6 deletions(-)
> 

Reviewed-by: Weijie Gao <weijie.gao at mediatek.com>


More information about the U-Boot mailing list