[PATCH] cache: l2x0: Fix write to incorrect shared-override bit
Ley Foon Tan
ley.foon.tan at intel.com
Fri Apr 17 08:45:35 CEST 2020
The existing code write bit-0 for shared attribute override enable bit.
It should be bit-22 based on cache controller specification [1].
[1] http://infocenter.arm.com/help/topic/com.arm.doc.ddi0246f/DDI0246F_l2c310_r3p2_trm.pdf
Signed-off-by: Ley Foon Tan <ley.foon.tan at intel.com>
---
drivers/cache/cache-l2x0.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/cache/cache-l2x0.c b/drivers/cache/cache-l2x0.c
index 67c752d076f2..226824c2832e 100644
--- a/drivers/cache/cache-l2x0.c
+++ b/drivers/cache/cache-l2x0.c
@@ -33,8 +33,8 @@ static void l2c310_of_parse_and_init(struct udevice *dev)
saved_reg &= ~L310_AUX_CTRL_INST_PREFETCH_MASK;
}
- saved_reg |= dev_read_bool(dev, "arm,shared-override");
- writel(saved_reg, ®s->pl310_aux_ctrl);
+ if (dev_read_bool(dev, "arm,shared-override"))
+ saved_reg |= L310_SHARED_ATT_OVERRIDE_ENABLE;
saved_reg = readl(®s->pl310_tag_latency_ctrl);
if (!dev_read_u32_array(dev, "arm,tag-latency", tag, 3))
--
2.19.0
More information about the U-Boot
mailing list