[PATCH v5 3/6] log: output for CONFIG_LOG=n

Tom Rini trini at konsulko.com
Wed Apr 22 21:01:10 CEST 2020


On Wed, Apr 22, 2020 at 09:00:02PM +0200, Marek Vasut wrote:
> On 2/26/20 9:48 PM, Heinrich Schuchardt wrote:
> > If CONFIG_LOG=n, we should still output errors, warnings, notices, infos,
> > and for DEBUG=1 also debug messages.
> > 
> > Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> > Reviewed-by: Simon Glass <sjg at chromium.org>
> 
> NAK
> 
> This patch grows SoCFPGA SPL size by more than 6 bytes, and considering
> the recent discussion, I believe it was made very clear that any growth
> in SPL size is not allowed. I am surprised that this was not caught earlier.
> 
> So, please revert this patch.
> 
> I see the following with socfpga_cyclone5_defconfig
> 
>    text    data     bss     dec     hex filename
> - 52235    1916      16   54167    d397 spl/u-boot-spl
> + 52319    1916      16   54251    d3eb spl/u-boot-spl

Bugfix of previously important prints being missing.  Fix your patch and
quit trolling please.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20200422/ee3409db/attachment.sig>


More information about the U-Boot mailing list