[PATCH v5 3/6] log: output for CONFIG_LOG=n

Marek Vasut marex at denx.de
Wed Apr 22 21:10:40 CEST 2020


On 4/22/20 9:01 PM, Tom Rini wrote:
> On Wed, Apr 22, 2020 at 09:00:02PM +0200, Marek Vasut wrote:
>> On 2/26/20 9:48 PM, Heinrich Schuchardt wrote:
>>> If CONFIG_LOG=n, we should still output errors, warnings, notices, infos,
>>> and for DEBUG=1 also debug messages.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> Reviewed-by: Simon Glass <sjg at chromium.org>
>>
>> NAK
>>
>> This patch grows SoCFPGA SPL size by more than 6 bytes, and considering
>> the recent discussion, I believe it was made very clear that any growth
>> in SPL size is not allowed. I am surprised that this was not caught earlier.
>>
>> So, please revert this patch.
>>
>> I see the following with socfpga_cyclone5_defconfig
>>
>>    text    data     bss     dec     hex filename
>> - 52235    1916      16   54167    d397 spl/u-boot-spl
>> + 52319    1916      16   54251    d3eb spl/u-boot-spl
> 
> Bugfix of previously important prints being missing.
So, can you please clarify what the rule for acceptable SPL growth is?


More information about the U-Boot mailing list