[PATCH V3 3/6] ARM: stm32: Implement board coding on AV96

[Patrick DELAUNAY]

Dear Marek,

> From: Marek Vasut <marex at denx.de>
> Sent: mercredi 22 avril 2020 17:19
> 
> On 4/22/20 5:04 PM, Patrick DELAUNAY wrote:
> > Hi Marek,
> 
> Hi,
> 
> >> From: Marek Vasut <marex at denx.de>
> >> Sent: mercredi 22 avril 2020 13:18
> >>
> >> The AV96 board does exist in multiple variants. To cater for all of
> >> them, implement board code handling. There are two GPIOs which code
> >> the type of the board, read them out and use the value to pick the correct
> device tree from an fitImage.
> >>
> >> Reviewed-by: Patrick Delaunay <patrick.delaunay at st.com>
> >> Signed-off-by: Marek Vasut <marex at denx.de>
> >> Cc: Manivannan Sadhasivam <manivannan.sadhasivam at linaro.org>
> >> Cc: Patrick Delaunay <patrick.delaunay at st.com>
> >> Cc: Patrice Chotard <patrice.chotard at st.com>
> >> ---
> >> V2: No change
> >> V3: Drop dm-pre-reloc and gpio-cells from config node
> >> ---
> >>  arch/arm/dts/stm32mp15xx-dhcom-u-boot.dtsi    |  1 +
> >>  .../stm32mp15xx-dhcor-avenger96-u-boot.dtsi   |  1 +
> >>  arch/arm/dts/stm32mp15xx-dhcor-u-boot.dtsi    |  7 +++
> >>  board/dhelectronics/dh_stm32mp1/Kconfig       |  2 +-
> >>  board/dhelectronics/dh_stm32mp1/board.c       | 61 +++++++++++++++++++
> >>  .../dh_stm32mp1/u-boot-dhcom.its              | 39 ++++++++++++
> >>  .../dh_stm32mp1/u-boot-dhcor.its              | 39 ++++++++++++
> >>  configs/stm32mp15_dhcom_basic_defconfig       |  3 +
> >>  configs/stm32mp15_dhcor_basic_defconfig       |  3 +
> >>  include/configs/dh_stm32mp1.h                 | 15 +++++
> >>  10 files changed, 170 insertions(+), 1 deletion(-)  create mode
> >> 100644 board/dhelectronics/dh_stm32mp1/u-boot-dhcom.its
> >>  create mode 100644 board/dhelectronics/dh_stm32mp1/u-boot-dhcor.its
> >>  create mode 100644 include/configs/dh_stm32mp1.h
> >>
> >
> > I have 2 compilation issue on this patch with buildman
> >


[...]

> >
> > And you are the first user of CONFIG_SPL_FIT_SOURCE...
> 
> Most certainly not the first, this was used before.
> 

At least the last one 😊 checked by grep.

> > I want to propose to copy the file with:
> >
> > ----------------------------------- Makefile


[....]

> > But then you need to update the patch in .its files....
> >
> > => remove no more necessary "../../../"
> 
> Cam you send this patch, so I can rebase on top of it ?

Done in :

[PATCH] Makefile: copy SPL_FIT_SOURCE in build directory
http://patchwork.ozlabs.org/project/uboot/patch/20200423093845.1.Idf086bdb530238139f0066b3fecc01529d7c0b7d@changeid/

Regards

Patrick